Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French Nouns Transformation #247

Closed

Conversation

Louanes1
Copy link

No description provided.

@Louanes1 Louanes1 changed the title Added my french_noun_synonym transformation French Noun Synonym Transformation Aug 31, 2021
@Louanes1 Louanes1 changed the title French Noun Synonym Transformation French Nouns Transformation Aug 31, 2021
@Louanes1
Copy link
Author

Louanes1 commented Sep 7, 2021

Hello @kaustubhdhole , I got this error when trying to build:
image

have you encountered anything similar ?
I specified the encoding within the setup.py file but I don't think I am supposed to change anything in there.

@AbinayaM02
Copy link
Collaborator

AbinayaM02 commented Sep 21, 2021

Hello @kaustubhdhole , I got this error when trying to build:
image

have you encountered anything similar ?
I specified the encoding within the setup.py file but I don't think I am supposed to change anything in there.

Hi @Louanes1 : It should resolve the workflow failure. You should revert the change in setup.py. That's the reason for the failure. Also, please pull the latest code.

@mille-s
Copy link
Contributor

mille-s commented Sep 21, 2021

Should there be just one transformation for Verbs #250, Nouns and Adjectives #249, since the method seems to be the same? The transformation could be called "Lexical susbstitutions for French".

@tuetschek
Copy link
Collaborator

Hi, I've had a look, I like the idea and the dependencies seem OK, but I agree with @mille-s that merging this with #249 and #250 would make much more sense (you could add a parameter specifying which PoS to replace).

@kaustubhdhole
Copy link
Collaborator

Agree with the comments above. By default, you can return all (nouns,adjectives and adverbs) and still have it parametrized. Since we are tabulating the PRs, I am closing this. Please address all the suggested changes in all the 3 PRs to #250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants